Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 feat(style): Space and Grid gap style is compatible with browsers below Chrome 84 #344

Merged
merged 8 commits into from
Dec 13, 2023
Merged

🔥 feat(style): Space and Grid gap style is compatible with browsers below Chrome 84 #344

merged 8 commits into from
Dec 13, 2023

Conversation

wdyea-ya
Copy link
Collaborator

@wdyea-ya wdyea-ya commented Dec 7, 2023 •
edited by dengfuping
Loading

📦 Modified package

  • @oceanbase/design
  • @oceanbase/ui
  • @oceanbase/icons
  • @oceanbase/charts
  • @oceanbase/util
  • @oceanbase/codemod
  • Other (about what?)

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

  • None.

💡 Background and solution

Space 组件和 Gird 的组件使用 row-gap + flex 进行布局，在 Chrome 84 以下的低版本浏览器中不支持该种布局，导致样式异常，因此需要对低版本浏览器进行兼容。

image

Before After
Space image image
Grid image image

📝 Changelog

Language Changelog
🇺🇸 English 🔥 Space and Grid gap style is compatible with browsers below Chrome 84.
🇨🇳 Chinese 🔥 Space 和 Grid 组件的间距样式兼容 Chrome 84 以下的浏览器。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Tests is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited
Loading

@wdyea-ya wdyea-ya requested a review from dengfuping December 7, 2023 06:58
dengfuping
dengfuping requested changes Dec 11, 2023
View reviewed changes
@wdyea-ya wdyea-ya requested a review from dengfuping December 13, 2023 05:40
@dengfuping dengfuping changed the title fix(style): Compatible with flex gap styles in the bottom browser 🔥 feat(style): Space and Grid gap style is compatible with browsers below Chrome 84 Dec 13, 2023
@dengfuping dengfuping changed the title 🔥 feat(style): Space and Grid gap style is compatible with browsers below Chrome 84 🔥 feat(style): Space and Grid row-gap style is compatible with browsers below Chrome 84 Dec 13, 2023
@dengfuping dengfuping changed the title 🔥 feat(style): Space and Grid row-gap style is compatible with browsers below Chrome 84 🔥 feat(style): Space and Grid gap style is compatible with browsers below Chrome 84 Dec 13, 2023
@dengfuping dengfuping merged commit b50b399 into master Dec 13, 2023
@dengfuping dengfuping mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dengfuping dengfuping dengfuping approved these changes

Assignees
No one assigned
Labels
Col feature Grid @oceanbase/design Row Space
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wdyea-ya @dengfuping