Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): [ranger] support rest props for quick picker #799

Merged

Conversation

wzc520pyfm
Copy link
Collaborator

@wzc520pyfm wzc520pyfm commented Oct 29, 2024

📦 Modified package

  • @oceanbase/design
  • @oceanbase/ui
  • @oceanbase/icons
  • @oceanbase/charts
  • @oceanbase/util
  • @oceanbase/codemod
  • Other (about what?)

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

When I needed to set attributes for Antd'Dropdown, I found that it was not possible to pass it through to QuickPicker, so I supplemented the attribute pass-through.

📝 Changelog

image

Language Changelog
🇺🇸 English support rest props for quick picker
🇨🇳 Chinese Ranger组件支持透传props到QuickPicker

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Tests is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@wzc520pyfm wzc520pyfm marked this pull request as ready for review October 29, 2024 14:12
@wzc520pyfm wzc520pyfm changed the base branch from master to feature October 29, 2024 15:48
@dengfuping
Copy link
Collaborator

改动不大,合并到 master 吧

@wzc520pyfm wzc520pyfm changed the base branch from feature to master October 30, 2024 02:43
@wzc520pyfm wzc520pyfm requested a review from dengfuping October 30, 2024 02:49
@dengfuping dengfuping merged commit 63b09a0 into oceanbase:master Oct 31, 2024
5 of 6 checks passed
@wzc520pyfm wzc520pyfm deleted the feat/ranger-support-quick-picker-props branch January 10, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants