Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve(ui): Remove PageContainer header paddingBlockStart #817

Merged
merged 1 commit into from
Nov 10, 2024
Merged

improve(ui): Remove PageContainer header paddingBlockStart #817

merged 1 commit into from
Nov 10, 2024

Conversation

dengfuping
Copy link
Collaborator

@dengfuping dengfuping commented Nov 10, 2024 •
edited
Loading

📦 Modified package

  • @oceanbase/design
  • @oceanbase/ui
  • @oceanbase/icons
  • @oceanbase/charts
  • @oceanbase/util
  • @oceanbase/codemod
  • Other (about what?)

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Before After
image image

📝 Changelog

Language Changelog
🇺🇸 English -
🇨🇳 Chinese - 💄 去掉 PageContainer 页头的上内间距，让页面布局更加紧凑。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Tests is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2024 •
edited
Loading

@dengfuping dengfuping changed the title improve(ui): PageContainer header paddingBlockStart change to 0px improve(ui): Remove PageContainer header paddingBlockStart Nov 10, 2024
@dengfuping dengfuping merged commit 71c20c6 into master Nov 10, 2024
6 checks passed
@dengfuping dengfuping mentioned this pull request Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
improvement @oceanbase/ui PageContainer style
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dengfuping