Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple bugfixes for
CARQ
correction ofOFCL
track #68Multiple bugfixes for
CARQ
correction ofOFCL
track #68Changes from 7 commits
cb53e04
a7a3825
c17afdb
c5751f7
2ebcc72
4097d56
7db6cb0
aa94d10
3bc58c4
e6b777d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original values for these variables from the ATCF file were not empty, but they were
0
instead. So, the correction logic would ignore them and didn't fix the incorrect0
value. #64There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first
CARQ
track could be a-24
hour "forecast", which has missing values for variables of interest.iloc[0]
just gets the first entry ofcarq_forecast
dataframe instead of getting the first hour-0 entryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prior to the fixes in this pull, this update
forecast
data frame was not stored anywhere and the corrections were discarded. #66There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for
CARQ
correction is now moved to a standalone functionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The corrected tracks are now converted back into a dataframe which replaces the original one #66
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
forecast_hours
data is used for sorting the dataframe. Because the data was originally ofstring
type, the sort used to happen at character level (i.e. first1
s and then2
s, etc. so that120
would come before24
). Now this issue is fixed by usingint
type #67There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CARQ
track entry to be used is now the first entry of hour-0 forecast (i.e.34 kt
) #65There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The values are now checked for both
NA
as well as0
to indicate the missing data. #64There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the correction is stored in the
corr_ofcl_tracks
which replaces the values in the original forecast track. #66