Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI tests #160

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Fix CI tests #160

merged 5 commits into from
Sep 11, 2024

Conversation

SorooshMani-NOAA
Copy link
Contributor

Related to #159 #158

@SorooshMani-NOAA SorooshMani-NOAA self-assigned this Sep 4, 2024
@SorooshMani-NOAA
Copy link
Contributor Author

@pmav99 if all looks good when we merge this we can create new release and then start merging the GSoC PRs. We can also address the OFS ticket later.

Note that I removed all coops .yaml files and ran tests with -k coops --record-mode=all; then for those coops yamls that were not repleced I reverted back (probably I didn't really need to!). Please let me know if you see anything suspicious with the new recordings.

@SorooshMani-NOAA SorooshMani-NOAA merged commit 02d9125 into oceanmodeling:master Sep 11, 2024
8 checks passed
@SorooshMani-NOAA SorooshMani-NOAA deleted the bugfix/ci_test branch September 11, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmav99 pmav99 Awaiting requested review from pmav99

Assignees

@SorooshMani-NOAA SorooshMani-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SorooshMani-NOAA