Fix infinite loading on file info #1977
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
bogdanfazakas
changed the title
bogdanfazakas
requested review from
jamiehewitt15,
mihaisc and
EnzoVezzaro
as code owners
|
I opened up the test asset page and it's failing to load the price, just seems to be continuously loading. Is this due to the ocean.js version bump that's required?
|
no it should not be related to ocean.js update, but the asset above requires about 1 min wait time untill the fileInfo request fails due to bag gateway, see print screen attached 
|
|
I tested it out a bit and I've seen the errors displayed, but the spinner is still loading. |
|
Noup, I was wrong. Waited a bit longer and I the spinner stoped and another error displayed |
|
Code Climate has analyzed commit 277ccb5 and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 20.1% (0.0% change). View more on Code Climate. |
|
good to go? i see it was approved |
yes but Ana is not a code owner so i should have bypassed the protections to merge it 😄 |
Fixes #1938 .
Changes proposed in this PR:
NOTE: requires ocean.js lib 3.1.3 (PR uses pre release ocean.js lib 3.1.3-next.1)
test asset: https://market-git-fix-infinite-file-error-handling-oceanprotocol.vercel.app/asset/did:op:8de687b14e5181c160a8ab602038f16ddc6557ed3ab494d4bc488d221686164d