Fix: make fetch_data check for rows properly #19

alexclavel-ocient · 2023-03-09T20:43:06Z

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

jwilliams-ocient

Awesome - can you link a JIRA ticket here so we can track this? We should add a check in a system test for this. I wouldn't focus on that now though

jwilliams-ocient · 2023-03-09T20:45:47Z

superset/db_engine_specs/ocient.py

@@ -256,7 +256,8 @@ def fetch_data(
                ]
            raise exception

-        if len(rows) > 0 and type(rows[0]).__name__ == rows:
+        # TODO: Unsure if we need to verify that we are receiving rows:


Fix: make fetch_data check for rows properly

11cb054

alexclavel-ocient requested a review from jwilliams-ocient March 9, 2023 20:45

jwilliams-ocient approved these changes Mar 9, 2023

View reviewed changes

jwilliams-ocient reviewed Mar 9, 2023

View reviewed changes

alexclavel-ocient merged commit c01ccda into master Mar 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: make fetch_data check for rows properly #19

Fix: make fetch_data check for rows properly #19

alexclavel-ocient commented Mar 9, 2023

jwilliams-ocient left a comment

jwilliams-ocient Mar 9, 2023

Fix: make fetch_data check for rows properly #19

Fix: make fetch_data check for rows properly #19

Conversation

alexclavel-ocient commented Mar 9, 2023

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

jwilliams-ocient left a comment

Choose a reason for hiding this comment

jwilliams-ocient Mar 9, 2023

Choose a reason for hiding this comment