Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB-22748 Fix canceling queries in Superset #2

Merged
merged 12 commits into from
Jan 30, 2023

Conversation

alexclavel-ocient
Copy link

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

superset/db_engine_specs/ocient.py Outdated Show resolved Hide resolved
superset/db_engine_specs/ocient.py Outdated Show resolved Hide resolved
superset/db_engine_specs/ocient.py Outdated Show resolved Hide resolved
superset/db_engine_specs/ocient.py Outdated Show resolved Hide resolved
superset/db_engine_specs/ocient.py Outdated Show resolved Hide resolved
superset/db_engine_specs/ocient.py Outdated Show resolved Hide resolved
superset/db_engine_specs/ocient.py Outdated Show resolved Hide resolved
superset/db_engine_specs/ocient.py Outdated Show resolved Hide resolved
superset/db_engine_specs/ocient.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jwilliams-ocient jwilliams-ocient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close! There are a couple of things to fix

superset/db_engine_specs/ocient.py Outdated Show resolved Hide resolved
superset/db_engine_specs/ocient.py Outdated Show resolved Hide resolved
superset/db_engine_specs/ocient.py Outdated Show resolved Hide resolved
superset/db_engine_specs/ocient.py Outdated Show resolved Hide resolved
superset/db_engine_specs/ocient.py Outdated Show resolved Hide resolved
superset/db_engine_specs/ocient.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jwilliams-ocient jwilliams-ocient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good! Thank you for addressing the thread safety concerns

superset/db_engine_specs/ocient.py Show resolved Hide resolved
@alexclavel-ocient alexclavel-ocient merged commit 6c1d956 into master Jan 30, 2023
@alexclavel-ocient alexclavel-ocient deleted the user/aclavel/DB-22748 branch January 30, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants