Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build[pyocient]: set min version for pyocient #20

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

jwilliams-ocient
Copy link
Collaborator

@jwilliams-ocient jwilliams-ocient commented Apr 10, 2023

  • v1.0.15 removes upper bound on protobuf version (conflict)

SUMMARY

This PR resolves the final dependency conflict and is the last known hurdle preventing merge.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

(bazel v2.2.4) jwilliams@jwilliams-dev0:/ocient/db/superset (master)$ python3 -m venv .venv
(bazel v2.2.4) jwilliams@jwilliams-dev0:/ocient/db/superset (master)$ source .venv/bin/activate
(.venv) (bazel v2.2.4) jwilliams@jwilliams-dev0:/ocient/db/superset (master)$ pip-compile-multi
Locking requirements/base.in to requirements/base.txt. References: []
Locking requirements/integration.in to requirements/integration.txt. References: []
Locking requirements/development.in to requirements/development.txt. References: ['requirements/base.in']
Locking requirements/docker.in to requirements/docker.txt. References: ['requirements/base.in']
Locking requirements/local.in to requirements/local.txt. References: ['requirements/base.in', 'requirements/development.in']
Locking requirements/testing.in to requirements/testing.txt. References: ['requirements/base.in', 'requirements/development.in', 'requirements/integration.in']

TESTING INSTRUCTIONS

To test, checkout the superset repo and run pip-compile-multi.

# Create scratch env
python3 -m venv .venv
source .venv/bin/activate

# Run pip-compile-multi
pip-compile-multi

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

 * v1.0.15 removes upper bound on protobuf version (conflict)
@jwilliams-ocient jwilliams-ocient merged commit 1f1c5a3 into master Apr 11, 2023
@jwilliams-ocient jwilliams-ocient deleted the user/jwilliams/pyocient-v1.0.15 branch April 11, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants