Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: code cleanup #4

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Conversation

jwilliams-ocient
Copy link
Collaborator

  • doc: add docstrings to functions
  • chore: clean up comments
  • perf: avoid copying row data that doesn't need to be sanitized

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

 * doc: add docstrings to functions
 * chore: clean up comments
 * perf: avoid copying row data that doesn't need to be sanitized
@jwilliams-ocient jwilliams-ocient merged commit e53ef91 into master Jan 23, 2023
@jwilliams-ocient jwilliams-ocient deleted the user/jwilliams/docstrings branch January 23, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants