DB-23237 Superset: datatypes are not being converted properly #8

alexclavel-ocient · 2023-01-30T19:08:13Z

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

superset/db_engine_specs/ocient.py

Fix: Replace invalid inplace type conversion

43decbd

jwilliams-ocient approved these changes Jan 30, 2023

View reviewed changes

superset/db_engine_specs/ocient.py Show resolved Hide resolved

jwilliams-ocient reviewed Jan 30, 2023

View reviewed changes

superset/db_engine_specs/ocient.py Outdated Show resolved Hide resolved

alexclavel-ocient requested a review from jwilliams-ocient January 30, 2023 19:15

alexclavel-ocient added 2 commits January 30, 2023 19:32

Nit: Add comment clarifying why we cannot update in place

72694a0

Nit: Generate functions based on cursor, not rows

63529b5

jwilliams-ocient approved these changes Jan 30, 2023

View reviewed changes

jwilliams-ocient merged commit 8059833 into master Jan 30, 2023

jwilliams-ocient deleted the user/aclavel/DB-23237 branch January 30, 2023 21:19

Provide feedback