feat: add topic separator option #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 3 3
Lines 15 15
Branches 2 2
======================================
Misses 15 15 Continue to review full report at Codecov.
|
RasPhilCo
commented
Feb 23, 2021
RasPhilCo
force-pushed
the
spaced-cmds
branch
from
27bd59d to
e306c55
Compare
RasPhilCo
changed the title
amphro
approved these changes
Feb 27, 2021
| const findId = (id: string, next: string[]): string | undefined => { | ||
| const idPresnet = (id: string) => ids.includes(id) | ||
| if (idPresnet(id) && !idPresnet(`${id}:${next[0]}`)) return id | ||
| if (next.length === 0 || next[0] === '--') return |
There was a problem hiding this comment.
Shouldn't this also return id?
There was a problem hiding this comment.
This is returning no match b/c the line would return the last valid id found. This line is saying, you didn't find anything to return (line above it) and you have no further argv to explore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.