fix: move ctor for command help class to its own function #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonnalley
approved these changes
Sep 13, 2021
peternhale
commented
Sep 13, 2021
|
Review comments captured in slack: https://platformcloud.slack.com/archives/C01U75RNU1G/p1631567124234900?thread_ts=1631553503.228700&cid=C01U75RNU1G |
peternhale
commented
Sep 14, 2021
| @@ -90,6 +90,8 @@ export class Help extends HelpBase { | |||
| } | |||
|
|
|||
| public async showHelp(argv: string[]) { | |||
| argv = argv.filter(arg => !getHelpFlagAdditions(this.config).includes(arg)) | |||
There was a problem hiding this comment.
Moved the stripping of help flags to showHelp from main.ts.
Other function call via showHelp expect the help flags to be removed.
| @@ -51,7 +51,6 @@ export async function run(argv = process.argv.slice(2), options?: Interfaces.Loa | |||
|
|
|||
| // display help version if applicable | |||
| if (helpAddition(argv, config)) { | |||
| argv = argv.filter(arg => !getHelpFlagAdditions(config).includes(arg)) | |||
There was a problem hiding this comment.
main.ts should not have any knowledge of what showHelp expects in argv, just pass the whole thing as is.
mdonnalley
approved these changes
Sep 14, 2021
RodEsp
reviewed
Sep 14, 2021
Comment on lines
-205
to
+207
| const help = new this.CommandHelpClass(command, this.config, this.opts) | ||
| const help = this.getCommandHelpClass(command) |
There was a problem hiding this comment.
Do we really need a whole new method for this if this is the only place it's used?
There was a problem hiding this comment.
@RodEsp This function will be overridden in the custom help class to allow the determination of short help.
RodEsp
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@W-9708749@