Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flags omit undefined for boolean flags #730

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

mshanemc
Copy link
Member

fix #729

[boolean flags have a built-in parse function even if the user doesn't specify it. It was easier to filter out undefined flags after calculating all the valus than to try to interfere with boolean flags before the default logic happens]

@mshanemc mshanemc requested a review from WillieRuemmele July 12, 2023 15:28
@WillieRuemmele
Copy link
Contributor

QA Notes


✅ : NUTs
✅ : git checkout main src && yarn build && yarn test which will validate that the new test is correct
✅ : all UTs pass

@WillieRuemmele WillieRuemmele merged commit 1711ecd into main Jul 12, 2023
@WillieRuemmele WillieRuemmele deleted the sm/omit-undefined-flags-from-parse branch July 12, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command.parse() method returns undefined flags
2 participants