fix: command not found on empty arg #886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royra
pushed a commit
to livecycle/preevy
that referenced
this pull request
Nov 26, 2023
patch for PR oclif/core#886
royra
pushed a commit
to livecycle/preevy
that referenced
this pull request
Nov 27, 2023
patch for PR oclif/core#886
royra
pushed a commit
to livecycle/preevy
that referenced
this pull request
Nov 27, 2023
patch for PR oclif/core#886
royra
pushed a commit
to livecycle/preevy
that referenced
this pull request
Nov 27, 2023
patch for PR oclif/core#886
royra
pushed a commit
to livecycle/preevy
that referenced
this pull request
Nov 28, 2023
* introduce default plugins, with configuration to disable them * refactor the GitHub plugin - rename package from `plugin-github-pr-link` to `plugin-github` to make room for more features - make configuration and flags more consistent - fix docs - make plugin enabled by default * fix: command id parsing bug in oclif. patch for PR oclif/core#886 * use patched @oclif/core * fix: empty args * ci: canary versions now use HEAD instead of merge commit
@mdonnalley you're right! I opened this PR with the wrong branch by mistake. when I tried to fix it just now it closed, so I reopened as #887. sorry for the mixup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an edge case bug in command ID parsing when the topic separator is a space
When
argvcontains an empty string arg, the command ID extracted contains an extra colon.An empty string arg can occur when running the CLI as part of a script.
Example:
Result: command not found "cmd"
Root cause: incorrect parsing in
standardizeIDFromArgv, which for the above example returnedcmd:as the command ID.