fix: hook should fire for all plugins before ui (#72)

oclif · Mar 20, 2019 · 8a6b091 · 8a6b091
1 parent 2281e86
commit 8a6b091
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -19,7 +19,7 @@
     "yarn": "^1.13.0"
   },
   "devDependencies": {
-    "@oclif/config": "^1.10.4",
+    "@oclif/config": "^1.12.11",
     "@oclif/dev-cli": "^1.19.4",
     "@oclif/errors": "^1.2.2",
     "@oclif/plugin-help": "^2.1.4",

diff --git a/src/commands/plugins/install.ts b/src/commands/plugins/install.ts
@@ -38,11 +38,11 @@ e.g. If you have a core plugin that has a 'hello' command, installing a user-ins
       name = aliases[name] || name
       let p = await this.parsePlugin(name)
       let plugin
+      await this.config.runHook('plugins:preinstall', {
+        plugin: p
+      })
       if (p.type === 'npm') {
         cli.action.start(`Installing plugin ${chalk.cyan(this.plugins.friendlyName(p.name))}`)
-        await this.config.runHook('plugins:preinstall', {
-          plugin: p
-        })
         plugin = await this.plugins.install(p.name, {tag: p.tag, force: flags.force})
       } else {
         cli.action.start(`Installing plugin ${chalk.cyan(p.url)}`)