fix: display nested plugins as a tree (#65)

package.json

@@ -8,7 +8,7 @@
     "@oclif/color": "^0.0.0",
     "@oclif/command": "^1.5.4",
     "chalk": "^2.4.1",
-    "cli-ux": "^4.9.3",
+    "cli-ux": "^5.0.0",
     "debug": "^4.1.0",
     "fs-extra": "^7.0.1",
     "http-call": "^5.2.2",
@@ -19,7 +19,7 @@
     "yarn": "^1.12.3"
   },
   "devDependencies": {
-    "@oclif/config": "^1.9.0",
+    "@oclif/config": "^1.10.4",
     "@oclif/dev-cli": "^1.19.4",
     "@oclif/errors": "^1.2.2",
     "@oclif/plugin-help": "^2.1.4",

src/commands/plugins/index.ts

@@ -1,5 +1,7 @@
 import color from '@oclif/color'
 import {Command, flags} from '@oclif/command'
+import {Plugin} from '@oclif/config'
+import {cli} from 'cli-ux'
 
 import Plugins from '../../plugins'
 import {sortBy} from '../../util'
@@ -24,12 +26,36 @@ export default class PluginsIndex extends Command {
       this.log('no plugins installed')
       return
     }
-    for (let plugin of plugins) {
-      let output = `${this.plugins.friendlyName(plugin.name)} ${color.dim(plugin.version)}`
-      if (plugin.type !== 'user') output += color.dim(` (${plugin.type})`)
-      if (plugin.type === 'link') output += ` ${plugin.root}`
-      else if (plugin.tag && plugin.tag !== 'latest') output += color.dim(` (${String(plugin.tag)})`)
-      this.log(output)
+    this.display(plugins as Plugin[])
+  }
+
+  private display(plugins: Plugin[]) {
+    for (let plugin of plugins.filter((p: Plugin) => !p.parent)) {
+      this.log(this.formatPlugin(plugin))
+      if (plugin.children.length) {
+        let tree = this.createTree(plugin)
+        tree.display(this.log)
+      }
     }
   }
+
+  private createTree(plugin: Plugin) {
+    let tree = cli.tree()
+    for (let p of plugin.children) {
+      const name = this.formatPlugin(p)
+      tree.insert(name, this.createTree(p))
+    }
+    return tree
+  }
+
+  private formatPlugin(plugin: any): string {
+    let output = `${this.plugins.friendlyName(plugin.name)} ${color.dim(plugin.version)}`
+    if (plugin.type !== 'user')
+      output += color.dim(` (${plugin.type})`)
+    if (plugin.type === 'link')
+      output += ` ${plugin.root}`
+    else if (plugin.tag && plugin.tag !== 'latest')
+      output += color.dim(` (${String(plugin.tag)})`)
+    return output
+  }
 }

src/commands/plugins/uninstall.ts

@@ -1,4 +1,5 @@
 import {Command, flags} from '@oclif/command'
+import {Plugin} from '@oclif/config'
 import cli from 'cli-ux'
 
 import Plugins from '../../plugins'
@@ -30,6 +31,10 @@ export default class PluginsUninstall extends Command {
       cli.action.start(`Uninstalling ${friendly}`)
       const unfriendly = await this.plugins.hasPlugin(plugin)
       if (!unfriendly) {
+        let p = this.config.plugins.find(p => p.name === plugin) as Plugin | undefined
+        if (p) {
+          if (p && p.parent) return this.error(`${friendly} is installed via plugin ${p.parent!.name}, uninstall ${p.parent!.name} instead`)
+        }
         return this.error(`${friendly} is not installed`)
       }
       await this.plugins.uninstall(unfriendly.name)