Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins cannot be installed from a private registry that requires login #282

Closed
peternhale opened this issue Jun 23, 2021 · 0 comments
Closed

Plugins cannot be installed from a private registry that requires login #282

peternhale opened this issue Jun 23, 2021 · 0 comments

Comments

@peternhale
Copy link
Contributor

During install, the command is use raw https requests to check if a module exists in an npm registry. If the registry is a private registry that requires authentication, the raw https request fails with a 401.
peternhale added a commit that referenced this issue Jun 23, 2021
@peternhale
fix: install should use npm to check registry
170fc73 
Modify plugins.ts#hasPackage to use npm instead of https to check if a package exists on the registry.
#282
@peternhale peternhale mentioned this issue Jun 23, 2021
Merged
peternhale added a commit that referenced this issue Jun 25, 2021
@peternhale
fix: install should use npm to check registry (#283)
a2e8180 
Modify plugins.ts#hasPackage to use npm instead of https to check if a package exists on the registry.
#282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mshanemc @peternhale