-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check for renamed yarn.lock during install #648
Conversation
src/plugins.ts
Outdated
await fs.promises.rename(path.join(root, 'oclif.lock'), path.join(root, 'yarn.lock')) | ||
await doRefresh() | ||
await fs.promises.unlink(path.join(root, 'yarn.lock')) | ||
} else if (await fileExists(path.join(root, 'yarn.lock'))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we check for yarn.lock
first? Say npm@10
comes out and it allows you to package a yarn.lock
. I could see a situation where someone has an old oclif.lock
checked into their repo (even though we discourage that here) and the shipped yarn.lock
would get overwritten with an old oclif.lock
.
QA NOTES
|
Looks great! |
oclif.lock
to see ifyarn
should be rerun with the--prod
flag@W-14010705@