Allow users to disable update checks #358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #279 This can speed up execution, reduce unnecessary network requests, and clean up log files.
|
Thanks for the contribution! Before we can merge this, we need @RealOrangeOne to sign the Salesforce.com Contributor License Agreement. |
|
(CLA signed) |
mdonnalley
added a commit
that referenced
this pull request
Oct 13, 2023
Merged
mshanemc
pushed a commit
that referenced
this pull request
Oct 17, 2023
* feat!: migrate to ESM BREAKING CHANGES: ESM and node 18 minimum * feat: add SKIP_UPDATE_CHECK env var (#358) * chore: bump @oclif/core * feat: make warning frequency configurable * feat: allow users to disable update checks Fixes #279 This can speed up execution, reduce unnecessary network requests, and clean up log files. * chore: code review * test: add real tests * chore: remove rogue console.log * fix: use scoped env var * chore: bump oclif/core * chore: update dev.cmd * chore: more code review * chore(release): 2.1.2-qa.0 [skip ci] * fix: use separate file for tracking last warning * chore(release): 2.1.2-qa.1 [skip ci] --------- Co-authored-by: Jake Howard <jake.howard@torchbox.com> Co-authored-by: svc-cli-bot <svc_cli_bot@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #279
This can speed up execution, reduce unnecessary network requests, and clean up log files.
I added the check in 2 places, to ensure both the prompt and update request are skipped.