Compiler warning about printing ImTextureID

[eliasdaler]

Hello, I've ignored this warning for quite some time, but I think that it's easy to deal with, but needs some discussion. Basically, it's this:

imgui.cpp:9626:245: warning: format specifies type 'void ' but the argument has type 'unsigned int' [-Wformat]
bool pcmd_node_open = ImGui::TreeNode((void)(pcmd - draw_list->CmdBuffer.begin()), "Draw %4d %s vtx, tex 0x%p, clip_rect (%4.0f,%4.0f)-(%4.0f,%4.0f)", pcmd->ElemCount, draw_list->IdxBuffer.Size > 0 ? "indexed" : "non-indexed", pcmd->TextureId, pcmd->ClipRect.x, pcmd->ClipRect.y, pcmd->ClipRect.z, pcmd->ClipRect.w);

Here, the problem is that ImTextureID is assumed to be void*, but in custom bindings another type may be used. In ImGui-SFML, it's unsigned int.

So, the way to deal with this is to make "0x%p" part of this format string modifiable. We can have something like ImTextureIDPrintSpecifier to allow bindings to define how ImTextureID should be printed. It can be "0x%p" by default, same as ImTextureID is void* by default.

Thoughts?

[ocornut]

Can't we just cast the value at the printf call site?

[eliasdaler]

We can, but we'll get something like "0x5", as if it was address, instead of just "5". (ImTextureID in ImGui-SFML is OpenGL's texture handle).

But yeah, it's better than nothing. :)

[ocornut]

This is fine. This printout is merely a debugging/auditing tool, if we wanted to decorate this properly we'd need higher level primitives (e.g. query texture name from id).

0x5 is hexadecimal, it doesn't mean it is an address.

[eliasdaler]

Okay, thanks!