Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse-wheel scroll behaviour over child windows #2604

Closed
Tom-Evers opened this issue Jun 3, 2019 · 3 comments
Closed

Mouse-wheel scroll behaviour over child windows #2604

Tom-Evers opened this issue Jun 3, 2019 · 3 comments
Milestone

Comments

@Tom-Evers
Copy link

Tom-Evers commented Jun 3, 2019

Version/Branch of Dear ImGui:

Version: 1.71
Branch: docking

Back-end/Renderer/Compiler/OS

Back-ends: imgui_impl_win32.cpp + imgui_impl_dx11.cpp
Operating System: Windows 10

My Issue/Question:
When scrolling a tall list that contains another scrollable field, that subfield 'captures' the mousewheel scroll action.
This should not be default behaviour: when the mouse does not move, the mousewheel should keep affecting the field that the scroll action originated in.

Screenshots/Video

bug

Standalone, minimal, complete and verifiable example:
Build and run the docking branch.

@ocornut
Copy link
Owner

ocornut commented Jun 3, 2019

This is an interesting idea, I admit I hadn't thought of doing it this way (locking the target scrolling window until moving the mouse again). I'll give it a try when possible. I think OS X behaves the same way as we currently do. Also see #1245

@ocornut ocornut closed this as completed Jun 5, 2019
@ocornut ocornut reopened this Jun 5, 2019
@ocornut
Copy link
Owner

ocornut commented Jun 5, 2019

(Apologies, I have posted a message stating this was fixed but was thinking of a totally different issue. Deleted the wrong message and re-opened this.)

@ocornut ocornut changed the title Odd default scroll behaviour Mouse-wheel scroll behaviour over child windows Jun 7, 2019
@ocornut ocornut added this to the v1.72 milestone Jul 14, 2019
ocornut added a commit that referenced this issue Jul 23, 2019
…l the mouse is moved again or until a short delay expires (2 seconds). This allow uninterrupted scroll even if child windows are passing under the mouse cursor. (#2604)
@ocornut
Copy link
Owner

ocornut commented Jul 23, 2019

Hello @Tom-Evers
I have now implemented this feature and pushed it into master. It will be merged in docking shortly (you may merge it ahead if you want).
Commit:
26f14e0

Very happy with this improvement!

@ocornut ocornut closed this as completed Dec 5, 2019
ocornut added a commit that referenced this issue Oct 4, 2022
… also gets reset whenever scrolling again (#2604) + small refactor

Somehow interesting for (#3795, #4559). sorry this will break PR for 3795 but we got the info.
ocornut added a commit that referenced this issue Oct 4, 2022
…lly from touch pad events) incorrectly bubbling up and locking scrolling in a parent window. (#4559, #2604)
ocornut added a commit that referenced this issue Oct 4, 2022
…ly from touch pad events) are incorrectly locking scrolling in a parent window. (#4559, #3795, #2604)
ocornut added a commit that referenced this issue Oct 6, 2022
… misc refactor (#2604, #3795, #4559)

The refactor are designed to minimize the diff for changes needed for #3795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants