-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vulkan rendering backend example #531
Comments
There's not much point in providing millions of examples. While I probably won't mind one I don't feel this should be in an explicit Issue list. If you have a serious PR why not. Note:
|
But using vulkan vs. opengl in glfw is totally different. |
Hes saying that glfw will do the input/window creation, but can use vulkan instead of ogl: http://www.glfw.org/docs/3.2/vulkan.html so it isn't totally different at all. |
Thats a good point - so we could add a glfw+vulkan example if someone wants to make it. I would imagine that anyone who wants to spend time with vulkan wont have difficulties creating the 30ish lines render function. Concerns:
|
@ocornut I have made a ImGui Vulkan renderer, which is available here. |
Hello Raul, thanks for posting that. I would like to add a Vulkan example but it would need to more closely follow the structure of other examples. Your code could be used as a base reference to build such example but it would need some work in refactoring it. I probably won't have time to do it myself but would take such PR. |
And frankly I'd prefer if the example supported multiple frames in flight. Your code uses the render-and-wait approach and creates and allocates all the resources needed for the frame when rendering and after the wait they get destroyed again. Delaying the cleanup of resources (or better yet put them in a pool for reuse) is more complicated but would utilize the cpu and gpu much more effectively There is a similar issue with the D3D12 example pull request. |
Happy to have whatever makes more sense in Vulkan (up for debate here, I don't know anything about Vulkan) but it still would be preferable to design the example as close as possible to the others in term of end-user API whenever possible, folder structure, shader embedded in source code for maximum portability.,etc. |
Also see #549 "Vulkan Example" |
Done, merged Vulkan example from #549 today. |
No description provided.
The text was updated successfully, but these errors were encountered: