-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vulkan Example #549
Vulkan Example #549
Conversation
Loftilus
commented
Mar 9, 2016
- This example needs an update version of GLFW.
- It currently uses the Vulkan headers from the GLFW repo. We can maybe put that in the libs folder?
- To keep the code compact i decided to not properly setup Vulkan in main. I don't know if this will be an issue.
} | ||
{ | ||
vkDestroySemaphore(g_Device, g_Semaphore[g_FrameIndex], g_Allocator); | ||
VkSemaphoreCreateInfo info = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't need to delete and recreate the semaphores.
Thanks. Will look at it when I have time. |
There is still interest in this. Hopefully it can be merged soon. |
You can probably merge them locally yourself and use the code already, nothing stops you from doing that :) This looks mostly good but still needs some cleanup, if a PR comes not following the style-syntax-coding convention of other examples very precisely, my heuristic tells me that it's coming with other issues. So as I understand the two shaders are built from source into SPV using the shell script and only the SPV is needed to run the example, not the shader sources? |
Merged (applied coding style changes but haven't changed the actual behavior apart from a few minor changes applied to other examples since this one was forked). The situation with building examples is a total mess and we should aim to provide more organized build scripts eventually (perhaps using genie). |