Offset tooltip and drag/drop position for touch based input

[catlowlevel]

Version/Branch of Dear ImGui:

docking

Back-ends:

imgui_impl_android.cpp + imgui_impl_opengl3.cpp

Compiler, OS:

ndk, Android

Full config/build information:

No response

Details:

because the content of the tooltip is kind of hard to see if the input is touch based (blocked by finger), i would like to offset the tooltip position.
right now im using this code

void ImGuiEx::HelpMarker(const char *desc)
{
    ImGui::TextDisabled("(?)");
    ImGuiIO &io = ImGui::GetIO();
    // offset the tooltip 
    if (ImGui::IsItemHovered(ImGuiHoveredFlags_ForTooltip) && io.MouseSource == ImGuiMouseSource_TouchScreen)
    {
        ImVec2 pos = io.MousePos;
        pos.y -= ImGui::GetFontSize() * 2;
        ImGui::SetNextWindowPos(pos, ImGuiCond_Always, ImVec2(0.5f, 1.0f));
    }
    if (ImGui::BeginItemTooltip())
    {
        ImGui::PushTextWrapPos(ImGui::GetFontSize() * 35.0f);
        ImGui::TextUnformatted(desc);
        ImGui::PopTextWrapPos();
        ImGui::EndTooltip();
    }
}

is this the correct way? im also using this with BeginDragDropSource, however, the drop target location remain in the touch position, which again is kind of blocked by the finger, so is it possible to also offset the BeginDragDropTarget accept position?

Screenshots/Video:

No response

Minimal, Complete and Verifiable Example code:

No response

[ocornut]

is this the correct way?

it is not incorrect, but I think the issue you are pointing at would be best corrected in the library itself and by default, so we should investigate that.

im also using this with BeginDragDropSource, however, the drop target location remain in the touch position

You could technically call SetNextWindowPos() before BeginDragDropSource(). But ditto I think it should be done in the library.

[ocornut]

It's not as simple as expected for a surprising reason: using a position pivot that is not (0,0) make it visible and problematic when a tooltip change from one another, e.g. color preview tooltip vs color drag tooltip. I'll need more time to fix it nicely.

To clarify: if the tooltip size changes then it affects the position using pivot, so there is a visible glitches where you see the new tooltip in one position then another the next frame.

[ocornut]

I have pushed f057541, 014b722 and 5109a77.
The second one aim to fix the issue visible when relying on pivot.
The third one moves the tooltip (and use pivot) for touch- that code is quite awkward right now as generally tooltip positioning is in need of a bit of a refactor. But I'm happy to add more to the fix as that'll be useful for the refactor.

Also amended test: ocornut/imgui_test_engine@5f61301

Let me know if that works for you!

[ocornut]

This broke positioning of tooltip when using keyboard/gamepad navigation.

[ocornut]

Fixed with 50de550