-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible problems with endianess #81
Comments
Hello,
There's no "need" to extend the ImBitmapFont class since it is meant to load that specific format. Why I might end up with is a way to load TTF via stb_truetype and still support Angel bitmap format as well. For now I'd rather close this to focus on important stuff, add a "Support big-endian" in the todo list. If someone shows up with that need they or us can find a solution. Unless you are feeling like investigating this on an actual big-endian architecture I'd close this and we can reopen in the future. |
Agreed: my main purpose was just to address a possible issue. |
It's a fair issue! I added a reference to the bug number to the ImGui TODO list. Thanks. |
The embedded font data now used a base85 encoded string processed byte a byte and should be working on big-endian machines. |
I switched the font back to regular encoding to reduce binary space, source code is in a way that is big-endianess compatible. |
I'm using a little endian machine.
I was wondering if the library would still work on big endian systems (I guess I'll never use one, but my mind seems to like to create problems...).
Possible issues I can see:
These problems could be solved in two ways:
a) creating all the binaries on the same machine they're supposed to be used.
b) using a more robust approach:
I don't think this is a high-priority problem [solution (a) above needs no code change], but maybe some note should be written about it...
The text was updated successfully, but these errors were encountered: