Examples: DirectX12: Allow x32-bit compilation #2406
Conversation
|
This solution is unfortunately invalid, as it would create a different layout for the structure containing ImTextureId depending on the compilation unit. This is why we usually require them to be in imconfig.h. |
|
Oh...Sorry about it! Haven't looked into imconfig.h yet. I'll have a look soon and see if something comes in mind. |
|
I'll re-open because even if the PR is not correct in-context, the underlying problem is. |
* [imgui] Split bindings to multiple features See #12250. I tested all the features on x86-windows, x64-windows, x64-windows-static and x64-linux triplets. Everything build fine except: - dx12-binding on x86-windows. There's an issue opened about it here : ocornut/imgui#2406 - allegro5-binding on x64-linux, because the current allegro5 port fails to build on this platform. Contrary to the previous port which simply copied the sources to a specific folder, bindings are now compiled with their dependencies. The only exception is Marmelade, because there's no port available for it yet. Unfortunately, I can't test the OSX and metal bindings. If someone using this platform could test it, it would be very much appreciated. :) * [imgui] Move port files to the correct folder * Update ports/imgui/CONTROL Co-authored-by: Rémy Tassoux <rt2@rasterizedworld.com> Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
|
Apologies @giladreich, I implemented essentially the same thing in d8d58b0 last month and forgot about this pull request. At least it's done now :) |
|
Hi @ocornut, thanks a lot for the update and I'm glad that it's now part of the master branch! :) |
Hey Omar :)
As discussed in #301 and #1641, I though it would be good idea to add this solution for now(possibly to change later), so the people that'll use the examples, will know how to compile it under x32 architecture without having to do extra research about it.
tbh, I also find this solution quiet friendly and simple for consumers to use.