-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added IME support for OSX examples #2598
Conversation
Thank you!
Some thoughts:
|
Unlike windows, macOS needs to implement NSTextInputClient in the content view. So there is no way to implement it simply in the callback function. |
The reason I didn't put the code into the existing file is that I want to share the code between the metal and opengl examples. Although opengl is not supported now. |
0c1e5bd
to
bb6a60b
Compare
8b83e0a
to
d735066
Compare
Hello @actboy168, |
b3b85d8
to
0755767
Compare
I think it's working fine now. |
This patch adds IME support for macOS and also fixes some input bugs, such as #2578.
Some TODO:
Editing Text
by itself. But this is not very important.Editing Text
, the IME cannot cover the cursor. That is to say,g.FontSize
cannot be subtracted here.imgui/imgui_widgets.cpp
Line 4043 in bff7202