Fix new window position Y coordinate calculation for OSX backend. #7101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to use the "first" (not the current) screen's height to calculate Y coordinate. By "first" I mean the screen that has (0;0) coordinate at the top left for ImGui and (0;0) at the bottom left for OSX.
|
Also #7028 looks good. |
|
Thank you. I have applied this and other things all-together as part of a683033. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe we need to use the "first" (not the "current") screen's height to calculate Y coordinate of a window.
By "first" I mean the screen that has (0;0) coordinate at the top left for ImGui and (0;0) at the bottom left for OSX.
Otherwise on secondary monitors it will behave like this: