Improve width computation in multi-components widget (#7120) #7121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous algorithm, all components were of the same width except for the last. That last one was using the remainder. This meant that any error in that common width (caused by the truncation to the nearest pixel/integer), was getting accumulated and propagated into that last component. The new algorithm avoid this issue by computing where each component should start, with the width being the difference between those locations. In essence, this spreads the errors over multiple components instead of just the last one.
|
Thanks for the PR, will try to look tomorrow. FYI for future things it is absolutely fine to post the issues/details in single PR # (vs opening both issues # and PR #) |
|
Ended up merging as 86512ea. Thank you! |
|
This broke layout when there's too little space for widgets. Working on a fix. |
|
I'm guessing the |
|
Pushed fix now + an extra tweak for ColorEdit4()!. |
ocornut
added a commit
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous algorithm, all components were of the same width except for the last. That last one was using the remainder.
This meant that any error in that common width (caused by the truncation to the nearest pixel/integer), was getting accumulated and propagated into that last component.
The new algorithm avoid this issue by computing where each component should start, with the width being the difference between those locations. In essence, this spreads the errors over multiple components instead of just the last one.