Fixing a crash in the wgpu backend when ClipRect is unclipped #7191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocornut
changed the title
ocornut
pushed a commit
that referenced
this pull request
Jan 3, 2024
|
Thanks! That's correct, the dimming layer injected below a modal popup use an odd ClipRect value (due to ahem, reasons): I took the liberty to rework your commit into e8dd47e, matching the style and comments used by Metal, Vulkan and SDL_Renderer backends which need the same thing. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a popup using Dear imgui, a grey transparent layer is rendered below the actual popup. This layer seems to have a size superior to the framebuffer size by a 1 pixel amount - which causes a crash in the wgpu backend one frame later.
Clamping the clip_min/clip_max to force them to be within [0, FrameBufferSize] is enough to fix the issue.