Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force centos stream to use ansible 2.9 like rhel8 #237

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

schabrolles
Copy link
Contributor

@schabrolles schabrolles commented Feb 24, 2022

since centos stream, the ansible version installed with yum install ansible is ansible-core 2.12.
This produce error when executing helpernode playbooks.

Using ansible.noarch force to use ansible 2.9 (like rhel8)

This is compatible with rhel8

@ppc64le-cloud-bot
Copy link
Contributor

Hi @schabrolles. Thanks for your PR.

I'm waiting for a ocp-power-automation member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@schabrolles
Copy link
Contributor Author

@Prajyot-Parab @mkumatag could you have a look on this ?

@mkumatag
Copy link
Member

mkumatag commented Mar 3, 2022

/cc @cs-zhang
/uncc

not involved in this project lately.

@ppc64le-cloud-bot ppc64le-cloud-bot requested review from cs-zhang and removed request for mkumatag March 3, 2022 09:18
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yussufsh will there be any specific concerns about this package change in future?

@yussufsh
Copy link
Contributor

yussufsh commented Mar 3, 2022

@schabrolles Can we use ansible-2.9.* instead to fix on the 2.9 version.

Copy link
Collaborator

@cs-zhang cs-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to ansible-2.9.* can prevent future changes to ansible packages. Also consistent to ocp4-upi-powervs.

Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@cs-zhang cs-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cs-zhang, schabrolles, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit f6e8b64 into ocp-power-automation:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants