Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default CNI to OVNKubernetes #257

Merged

Conversation

pravin-dsilva
Copy link
Collaborator

@pravin-dsilva pravin-dsilva commented Oct 20, 2022

With OCP 4.12, the default network type is OVNKubernetes
Reference: openshift/installer#6014

Signed-off-by: Pravin D'silva pravin.dsilva@ibm.com

Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

We need to set this default option only for the 4.12+ versions, any idea how do we handle that ?

Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@Rajalakshmi-Girish
Copy link

@pravin-dsilva: PR is not mergeable.

The PR state is: BLOCKED

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yussufsh
Copy link
Contributor

/approve

We are going to share variable file for each version and ask user to use a particular file while installing a required OCP version. The default variables will only support latest stable release.
Eg:

  • ocp-4.9.tfvars
  • ocp-4.10.tfvars

The docs need to change to show how to run the terraform command, terraform apply -var-file var.tfvars -var-file ocp-4.9.tfvars.

Signed-off-by: Pravin D'silva <pravin.dsilva@ibm.com>
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Prajyot-Parab, pravin-dsilva, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 4603033 into ocp-power-automation:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants