Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up import statements #143

Merged
merged 5 commits into from
Nov 14, 2016
Merged

Clean up import statements #143

merged 5 commits into from
Nov 14, 2016

Conversation

zuphilip
Copy link
Collaborator

@zuphilip zuphilip commented Nov 5, 2016

These two import statements were hidden
in the main content below, but already
present in the beginning, i.e. they were
duplicate.

These two import statements were hidden
in the main content below, but already
present in the beginning, i.e. they were
duplicate.
@zuphilip
Copy link
Collaborator Author

zuphilip commented Nov 5, 2016

Split of from #140

@zuphilip
Copy link
Collaborator Author

zuphilip commented Nov 5, 2016

@kba Feel free to add to this branch more code cleaning commits.

- split multi-module imports to single line
- remove duplicates and unused imports
- group: builtin, external, application
- split multi-module imports to lines
- remove gzip (code is commented out)
- import pylab once
@kba kba changed the title Delete two duplicate import statements Clean up import statements Nov 6, 2016
@zuphilip
Copy link
Collaborator Author

This looks ready now, right? I think, this should be fine to merge @kba.

@kba
Copy link
Collaborator

kba commented Nov 14, 2016

I still have commits removing the __all__ = ... in ocrolib/init.py and making the import * imports explicit but I'd prefer to test all the tools first. I'll post-pone those until CI and more tests.

@kba kba merged commit dd02fcc into master Nov 14, 2016
@kba kba deleted the cleaning branch November 14, 2016 18:19
@zuphilip
Copy link
Collaborator Author

Okay, thank you for the commits here!

You can open a new PR whenever the other commits are ready and tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants