split functions from nlbin #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuphilip
reviewed
Sep 21, 2017
ocropus-nlbin
Outdated
| print_info("# image is empty: %s" % (fname)) | ||
| return | ||
| image /= amax(image) | ||
| image = normalze(raw) |
|
Makes sense to split up, easier to follow. Maybe the method names could be less generic ( Need to test this, travis complains about undefined variables. |
|
@kba Could you give a better name to 'normalize' ? |
|
I renamed it |
|
Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process1 in nlbin is too long, I split some functions from process1.