Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Discovery software inventory class #1134

Merged
merged 5 commits into from
Jul 3, 2024
Merged

New Discovery software inventory class #1134

merged 5 commits into from
Jul 3, 2024

Conversation

jasonbreimer
Copy link
Contributor

New Discovery class for software inventory data captured via a log or collection process.

This new class is a companion and mirrors the Discovery class Device Inventory Info 5001.

Description of changes:

  1. This class models locally or scanned sourced software details.
  2. Primary using device, software package, and product objects.
  3. The Software Package object is to be used for Device specific software details.
  4. The Product object (optional) can be used to capture additional software product details as part of a vendor's software catalog.

@jasonbreimer
New software inventory class
2442e2c 
New class to capture software inventory data.

Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
@jasonbreimer jasonbreimer added enhancement New feature or request discovery Issues related to Discovery Category labels Jul 1, 2024
@mikeradka
Copy link
Contributor

Hi @jasonbreimer, take a look at the validation task, it looks like something may have failed against the metaschema.

@jasonbreimer
fix group issue found in validation
ae1e170 
primary group to context for Product object.

Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
@jasonbreimer
Merge branch 'main' into software_inventory
14f2a04
@jasonbreimer
Copy link
Contributor Author

Thanks @mikeradka!

floydtree
floydtree requested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@floydtree floydtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a small thing, can you add a Changelog entry for this?

@mikeradka mikeradka added non_breaking Non Breaking, backwards compatible changes v1.3.0 Changes marked for v1.3.0 of OCSF labels Jul 2, 2024
@jasonbreimer
Update CHANGELOG.md for ocsf#1134
5e6779d 
Update change log with details from PR 1134.

Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
@jasonbreimer
Merge branch 'main' into software_inventory
42d85dc
@jasonbreimer
Copy link
Contributor Author

Looks good! Just a small thing, can you add a Changelog entry for this?

Done! thank you!

zschmerber
zschmerber approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@zschmerber zschmerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work we can now capture CIS controls 1 & 2.!

@floydtree floydtree merged commit 8e00d68 into ocsf:main Jul 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zschmerber zschmerber zschmerber approved these changes

@floydtree floydtree floydtree approved these changes

@mikeradka mikeradka mikeradka approved these changes

@pagbabian-splunk pagbabian-splunk Awaiting requested review from pagbabian-splunk pagbabian-splunk is a code owner

@Aniak5 Aniak5 Awaiting requested review from Aniak5 Aniak5 is a code owner

Assignees
No one assigned
Labels
discovery Issues related to Discovery Category enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.3.0 Changes marked for v1.3.0 of OCSF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasonbreimer @mikeradka @zschmerber @floydtree