-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional metaschemas #867
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanisaac
added
enhancement
New feature or request
non_breaking
Non Breaking, backwards compatible changes
labels
Nov 22, 2023
…added to extension
…collapse attributes in event
floydtree
requested changes
Nov 27, 2023
floydtree
reviewed
Nov 28, 2023
@floydtree I think your comments are resolved, with the note that I have two follow-ups:
|
dkolbly
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge progress 🚀
floydtree
approved these changes
Dec 7, 2023
mikeradka
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
non_breaking
Non Breaking, backwards compatible changes
v1.1.0
Changes marked for v1.1.0 of OCSF
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
Part of #735
These metaschemas have been tested against a version of the
ocsf-validator
based on this PR: ocsf/ocsf-validator#3. As a result, the following issues were found:These should be resolved before merging this PR.
Description of changes:
This PR implements additional metaschemas for:
categories
dictionary
extension
include
profile
It also adds the following attributes:
@deprecated
sibling
And refactors the
$include
attribute to be more reusable, updating it as a result of #791 / #792.Finally, it adds additional constraints on attribute names according to the spec, as well as a
description
to the existingobject
andevent
types (and all new metaschemas). Descriptions of types and properties are quoted or paraphrased from either the https://github.com/ocsf/ocsf-docs repository or from documentation in this repository.