Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal to add Datastore Event Class 6005 #874

Merged
merged 73 commits into from
Dec 21, 2023
Merged

Proposal to add Datastore Event Class 6005 #874

merged 73 commits into from
Dec 21, 2023

Conversation

pladam
Copy link
Contributor

@pladam pladam commented Nov 30, 2023 •
edited
Loading

Related Issue: [DRAFT] Proposal to add Datastore Event Class 6005

Description of changes:

The following changes are required for this event class:

New Objects

  • database
  • databucket
  • table
  • query_info

pladam and others added 23 commits November 29, 2023 20:00
adding objects for datastore object
4ff894f
@pladam
Adding datastore attributes to dictionary.
94c6ece 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Delete objects/column.json
b4d1179 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Delete objects/row.json
873c04b 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
removing row and col from table object
b017d6c 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update dictionary.json
e6b88fc 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update database.json
5950802 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update databucket.json
0c6dac9 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update table.json
d22b85c 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update query_info.json
e01e1b1 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update query_info.json
1424e04 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update table.json
a4f0a94 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update database.json
b1909d0 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update databucket.json
8f2a654 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update database.json
d36a9dd 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update databucket.json
c77946c 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update databucket.json
e499bdc 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update database.json
73c7c0e 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update dictionary.json
fc9cc51 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update databucket.json
0ab6d39 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update database.json
e61873e 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update database.json
b574a0e 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update databucket.json
e88ea8b 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
floydtree
floydtree requested changes Dec 1, 2023
View reviewed changes
dictionary.json Outdated Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
@floydtree
Copy link
Contributor

Hey @Aniak5 would like to get your review on this one since you had created a similar class a few months back.

@pladam
Update dictionary.json
a554136 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update database.json
1b801e1 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update databucket.json
5485129 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update databucket.json
b8b338b 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update database.json
7aa4cee 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
zschmerber
zschmerber previously approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@zschmerber zschmerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the hard work on this.

@pagbabian-splunk
Copy link
Contributor

Looks good now for DML activities (data manipulation). Would there be events associated with DML activities (i.e. metadata create, update, delete; create table, update table, delete table)?

Aniak5
Aniak5 reviewed Dec 21, 2023
View reviewed changes
objects/database.json Outdated Show resolved Hide resolved
Aniak5
Aniak5 reviewed Dec 21, 2023
View reviewed changes
objects/databucket.json Outdated Show resolved Hide resolved
Aniak5
Aniak5 reviewed Dec 21, 2023
View reviewed changes
objects/databucket.json Outdated Show resolved Hide resolved
Aniak5
Aniak5 reviewed Dec 21, 2023
View reviewed changes
objects/query_info.json Outdated Show resolved Hide resolved
@pladam
Update datastore_activity.json
c047168 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update database.json
8f421fe 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update databucket.json
c9302fd 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update databucket.json
0c19600 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update query_info.json
21904fa 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update query_info.json
51465a1 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update query_info.json
563586b 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@pladam
Update query_info.json
ddb17bf 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
Aniak5
Aniak5 previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome @adplotzk, excited to finally have this event class!!

Aniak5
Aniak5 reviewed Dec 21, 2023
View reviewed changes
objects/table.json Outdated Show resolved Hide resolved
@Aniak5 Aniak5 self-requested a review December 21, 2023 15:01
@pladam
Update table.json
6a5d950 
Signed-off-by: Adam Gregory <64800793+pladam@users.noreply.github.com>
@floydtree floydtree merged commit 9bf6a6a into ocsf:main Dec 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aniak5 Aniak5 Aniak5 approved these changes

@zschmerber zschmerber zschmerber approved these changes

@floydtree floydtree floydtree approved these changes

@jp-harvey jp-harvey Awaiting requested review from jp-harvey

@adplotzk adplotzk Awaiting requested review from adplotzk

@irakledibm irakledibm Awaiting requested review from irakledibm

@mikeradka mikeradka Awaiting requested review from mikeradka mikeradka is a code owner

@pagbabian-splunk pagbabian-splunk Awaiting requested review from pagbabian-splunk pagbabian-splunk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pladam @floydtree @pagbabian-splunk @Aniak5 @zschmerber @mikeradka @adplotzk