Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative to #1360 #1362

Closed
wants to merge 1 commit into from
Closed

Alternative to #1360 #1362

wants to merge 1 commit into from

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Dec 16, 2022

vouillon
vouillon reviewed Dec 16, 2022
View reviewed changes
compiler/lib/effects.ml
let last_instrs, last = cps_last ~st block.branch ~k in
let body =
List.map block.body ~f:(fun i -> cps_instr ~st i)
@ alloc_jump_closures
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that in this case alloc_jump_closures defines a single function whose body is the block we are jumping to.

Suggested change
@ alloc_jump_closures

@vouillon
Copy link
Member

That should work, but I would rather go with a simple fix for now

@hhugo hhugo closed this Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vouillon vouillon vouillon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhugo @vouillon