-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Lwt_result
#247
add Lwt_result
#247
Conversation
We should have |
|
||
val return : 'a -> ('a, _) t | ||
|
||
val fail : 'b -> (_, 'b) t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried this name may be a little confusing when seen with Lwt.fail
. Would error
or maybe return_error
be clearer?
I'm considering adding something like val get_exn : ('a, exn) t -> 'a Lwt.t to go with |
|
I think we should deprecate them, in agreement with @Drup. |
See #226 and #242
This is very basic, I can expand as required by nitpickers ;)