Deprecate let%lwt at the module item level #733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
let%lwt
as a module item now produces a warning like this:Resolves #728.
I completely removed support for
let%lwt ... and ...
, because it was broken. This linelwt/src/ppx/ppx_lwt.ml
Line 140 in 18e990e
was accidentally inserting the identifier
gen_exp
into the output AST, because it is missing an[%e ...]
antiquotation, resulting in errors likeThis means that nobody has ever used
let%lwt ... and ...
successfully.I removed the warning that we were trying to print on
let%lwt rec ... and ...
, because, in this case, the warning seems to be ignored, and the output is simplywhether we try to add the warning or not. Given that we will already be discouraging
let%lwt
at structure item level withoutand
, I think it's fine to have just this uglier message.The result of these two changes is that we never try to interpret
let%lwt ... and ...
at all, simplifying the PPX a bit.