Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cppo as a build dependency for lwt_react. #946

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

rizo
Copy link
Contributor

@rizo rizo commented May 25, 2022

Similar to:

lwt/lwt.opam

Line 22 in 654952b

"cppo" {build & >= "1.1.0"}

I'm not sure if it should actually be moved from lwt.opam.

@raphael-proust
Copy link
Collaborator

I think that we also need it for unix. And unix is used in the tests for lwt.

So I don't think it should be moved.

@raphael-proust
Copy link
Collaborator

I've added an entry to the CHANGES. I think this MR is ready. @rizo do you agree? If so, I will merge.

@rizo
Copy link
Contributor Author

rizo commented Jun 2, 2022

All good, thanks @raphael-proust!

@raphael-proust raphael-proust merged commit 7fb41f8 into ocsigen:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants