HACK! Add a 2s delay before changing user to wait for the cohttp serv…

…er to be initialized Cohttp does not return after listening
ocsigen · Sep 30, 2022 · e11dbe8 · e11dbe8
1 parent f2abc32
commit e11dbe8
Showing 1 changed file with 15 additions and 8 deletions.
diff --git a/src/server/ocsigen_server.ml b/src/server/ocsigen_server.ml
@@ -371,14 +371,21 @@ let start ?config () =
          with e ->
            Lwt_log.ign_error ~section ~exn:e "Cannot create the command pipe"));
       (* I change the user for the process *)
-      (try
-         (if current_uid = 0
-         then
-           match user with None -> () | Some user -> Unix.initgroups user gid);
-         Unix.setgid gid; Unix.setuid uid
-       with (Unix.Unix_error _ | Failure _) as e ->
-         Lwt_log.ign_error ~section "Error: Wrong user or group";
-         raise e);
+      Lwt.async (fun () ->
+          Lwt_unix.sleep 2. >>= fun () ->
+          (*HACK! This is to wait for the server to be initialized by cohttp.
+                  How to do that in a cleaner way? *)
+          (try
+             (if current_uid = 0
+             then
+               match user with
+               | None -> ()
+               | Some user -> Unix.initgroups user gid);
+             Unix.setgid gid; Unix.setuid uid
+           with (Unix.Unix_error _ | Failure _) as e ->
+             Lwt_log.ign_error ~section "Error: Wrong user or group";
+             raise e);
+          Lwt.return ());
       let minthreads = Ocsigen_config.get_minthreads ()
       and maxthreads = Ocsigen_config.get_maxthreads () in
       if minthreads > maxthreads