Added support Node 12.x.x & 13.x.x. Updated deprecated functions for v8. #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st v8::String::Utf8Value
|
I can confirm this branch works on MacOS with Node v12.8.1 and Electron 7.1.2, thanks very much! |
This was referenced Nov 23, 2019
oktapodia
changed the title
|
Could we get a new release that includes this please? |
|
Will do as soon as possible |
Until the release is made you can change your package.json to point to the master branch: |
|
@dsteinman yeah, I have done that. I just prefer to use a released version. |
comcaptain
added a commit
to comcaptain/video-tagger
that referenced
this pull request
Dec 8, 2019
I used master because the change is not released yet, check octalmage/robotjs#523 for detail
|
Works on Ubuntu 18.04 and Node v12.13.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.