webhook: check for non-.sts.yaml files in .github/chainguard
#586
+585
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Hall <jason@chainguard.dev>
imjasonh
commented
Nov 5, 2024
imjasonh
changed the title
.sts.yaml files in .github/chainguard
imjasonh
changed the title
.sts.yaml files in .github/chainguard.github/chainguard
mattmoor
reviewed
Nov 5, 2024
mattmoor
reviewed
Nov 5, 2024
Signed-off-by: Jason Hall <jason@chainguard.dev>
cpanato
reviewed
Nov 5, 2024
|
@imjasonh |
jdolitsky
approved these changes
Jan 31, 2025
tcnghia
previously approved these changes
Jan 31, 2025
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An easy way to mess up Octo STS is to create a policy file named like
.github/chainguard/my-policy.yaml(ask me how I know! 😆)Webhook validation currently only validates the structure of valid policy file paths, but it will happily let you commit non-STS file paths, which cause problems later when you try to use
my-policy.This may break existing repos using Octo STS, but I'd guess that if they have a
my-policy.yamlthey won't also have a validmy-policy.sts.yaml, so any breakage would probably be highlighting a real issue. In any case, if that's a problem, we can make this a warning instead of a failing check, if we want to.