Fix project structure for distribution #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ross
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed elephant in the room by testing plugin only with
pip install -e <dir>.Current tagged version is distributed incorrectly, since v1 and v2 directories are not modules and
setup.pyskips them.I added
__init__.pyto directories fix this and checked it by installing using package directly from my fork viapip install git+https://github.com/dchudik/octodns-selectel.gitSo as far as I know there should be no more obstacles for correct packaging
We are sorry to bother you more because of that awkward mistake. Will you be able accept PR or you would prefer to re-tag?