Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade @octokit/auth-app #422

Merged
merged 1 commit into from
May 27, 2023
Merged

fix(deps): upgrade @octokit/auth-app #422

merged 1 commit into from
May 27, 2023

Conversation

wolfy1339
Copy link
Member

This should help make sure that users of CDNs like esm.sh get the correct working version.

Currently, it is loading version 4.0.10 of @octokit/auth-app which is a broken release

See octokit/octokit.js#2459 (comment) octokit/octokit.js#2450


Behavior

Before the change?

  • Users that are utilizing this package via a CDN of the likes of esm.sh or skypack, can run into caching issues where they aren't offered the latest release of a dependency.
  • Due to that, they might get a broken release of a dependency

After the change?

  • Upgrades the dependency that is causing problems to users

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Dependencies/code cleanup: Type: Maintenance

This should help make sure that users of CDNs like esm.sh get the correct working version.

Currently, it is loading version 4.0.10 of `@octokit/auth-app` which is a broken release
@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label May 27, 2023
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers!

@gr2m gr2m merged commit 536e56c into main May 27, 2023
@gr2m gr2m deleted the upgrade-auth-app branch May 27, 2023 01:33
@github-actions
Copy link

🎉 This PR is included in version 13.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

wolfy1339 added a commit to octokit/octokit.js that referenced this pull request May 27, 2023
Propogate octokit/app.js#422 to the `octokit` package to alleviate CDN caching issues
gr2m pushed a commit to octokit/octokit.js that referenced this pull request May 27, 2023
Propogate octokit/app.js#422 to the `octokit` package to alleviate CDN caching issues
wolfy1339 added a commit to octokit/octokit.js that referenced this pull request Jun 3, 2023
* fix(deps): upgrade `@octokit/app` (#2460)

Propogate octokit/app.js#422 to the `octokit` package to alleviate CDN caching issues

* build(deps): lock file maintenance

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @octokit/plugin-retry to v5

---------

Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kfcampbell added a commit that referenced this pull request Jun 14, 2023
* build(deps): lock file maintenance (#421)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): upgrade `@octokit/auth-app` (#422)

This should help make sure that users of CDNs like esm.sh get the correct working version.

Currently, it is loading version 4.0.10 of `@octokit/auth-app` which is a broken release

* build(deps): lock file maintenance

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @octokit/plugin-paginate-rest to v7

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
@github-actions
Copy link

🎉 This PR is included in version 14.0.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @beta released Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants