-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "cdn.pika.dev" with "cdn.skypack.dev" in README #191
Comments
Hey! can you let me fix this issue? This will be my first issue and hopefully this will break my bubble. |
Sure thing! It's all yours |
I'd would like to contribute in this. Will I? |
Of course you can, @archi15 ππΌ |
I had made the changes. Please review my PR #194 . Thanks! |
That's cool sorry I been away and just got this. |
@jefferycline1 would you like to send a pull request for this issue? Follow the instructions above βπΌ |
Yes sir I would be honored |
@@ |
Please go ahead @jefferycline1. Let us know if you have any questions |
@@ -32,11 +32,11 @@ For other GitHub authentication strategies see [octokit/auth.js](https://github. -Load <script type="module">
- import { createAppAuth } from "https://cdn.pika.dev/@octokit/auth-app";
+ import { createAppAuth } from "https://cdn.skypack.dev/@octokit/auth-app";
</script> |
That's not how you send a pull request. The easiest way is to edit the README.md file directly in the browser, see the instructions in the issue. Here is the documentation on how to edit files directly in the browser: https://docs.github.com/en/free-pro-team@latest/github/managing-files-in-a-repository/editing-files-in-your-repository This is the file you want to edit: https://github.com/octokit/auth-app.js/blob/master/README.md |
Hey! can you let me fix this issue? |
Sure thing ππΌ |
π This issue has been resolved in version 2.10.1 π The release is available on: Your semantic-release bot π¦π |
ππ₯β First Timers Only.
This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you π
About First Timers Only.
π€ What you will need to know.
The Pika CDN is now Skypack, see https://www.pika.dev/cdn. The CDN at https://cdn.pika.dev/ no longer works, all URLs must be replaced with the new CDN: https://cdn.skypack.dev/. We currently recommend using
cdn.pika.dev
to import the library into the browser, but that no longer works. Replacing it withcdn.skypack.dev
will make it work again.π Step by Step
π Claim this issue: Comment below.
More than one person can work on this issue, don't worry if it's already claimed.
π Update the file \README.md (press the little pen Icon) and edit as shown below:
πΎ Commit your changes
π Start a Pull Request. There are two ways how you can start a pull request:
π Done Ask for a review :)
If there are more than one pull requests with the correct change, we will merge the first one, but attribute the change to all authors who made the same change using
@Co-authored-by
, so yo can be sure your contribution will count.π€β Questions
Leave a comment below!
This issue was created by First-Timers-Bot.
The text was updated successfully, but these errors were encountered: