Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #211

Closed
wants to merge 1 commit into from
Closed

Update README.md #211

wants to merge 1 commit into from

Conversation

YubaNeupane
Copy link

No description provided.

@@ -32,11 +32,11 @@ For other GitHub authentication strategies see [octokit/auth.js](https://github.
Browsers
</th><td width=100%>

Load `@octokit/auth-app` directly from [cdn.pika.dev](https://cdn.pika.dev)
+Load `@octokit/auth-app` directly from [cdn.skypack.dev](https://cdn.skypack.dev)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added a + here, can you remove it please?

Suggested change
+Load `@octokit/auth-app` directly from [cdn.skypack.dev](https://cdn.skypack.dev)
Load `@octokit/auth-app` directly from [cdn.skypack.dev](https://cdn.skypack.dev)

@gr2m gr2m added Type: Bug Something isn't working as documented, or is being fixed documentation labels Nov 1, 2020
@gr2m gr2m linked an issue Nov 1, 2020 that may be closed by this pull request
5 tasks
@gr2m
Copy link
Contributor

gr2m commented Nov 1, 2020

Sorry @YubaNeupane, we had to go ahead and merge the open pull requests for #123. You didn’t get back to our change requests, so we had to close yours 😞 Good news is: we have some other issues marked as first-timers-only, you can find them here.

@gr2m gr2m closed this Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented, or is being fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "cdn.pika.dev" with "cdn.skypack.dev" in README
2 participants