feat: log option parameter #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2020 21:40
…e.warn implementation as described on #176
gr2m
approved these changes
Oct 15, 2020
There was a problem hiding this comment.
This looks great, it only requires a small change to get to the 100% code coverage. Thank you 💐
Because I show this live on raise.dev/hacktoberfest, I'll go ahead and do the changes myself so I can show some other things :)
Update: here is the video: https://www.twitch.tv/videos/771366287
gr2m
reviewed
Oct 15, 2020
gr2m
reviewed
Oct 15, 2020
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Oct 15, 2020
|
Hey @gr2m! Watched the whole twitch video, and thank you for the shout out! Super interesting workflow you have on how you are maintaining Octokit. I'm a big fan of automation myself, and the process you have is really insightful. Hopefully, I get to contribute on other Octokit projects as well! Thanks a lot! |
jefferycline1
pushed a commit
to jefferycline1/auth-app.js
that referenced
this pull request
Jul 5, 2021
Co-authored-by: Roman Balayan <roman.balayan@paymaya.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.